Fix ClientResponse.close releasing the connection instead of closing (a…

…io-libs#7869)
xiangxli · Dec 4, 2023 · 6799a0d · 6799a0d
1 parent badd54a
commit 6799a0d
Show file tree

Hide file tree

Showing 3 changed files with 264 additions and 238 deletions.
diff --git a/CHANGES/7869.bugfix b/CHANGES/7869.bugfix
@@ -0,0 +1 @@
+Fix ClientResponse.close releasing the connection instead of closing
diff --git a/aiohttp/client_reqrep.py b/aiohttp/client_reqrep.py
@@ -1033,7 +1033,9 @@ def close(self) -> None:
             return
 
         self._cleanup_writer()
-        self._release_connection()
+        if self._connection is not None:
+            self._connection.close()
+            self._connection = None
 
     def release(self) -> Any:
         if not self._released:
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix ClientResponse.close releasing the connection instead of closing