forked from Robbybp/idaes-pse
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt to new prescient plugin system #2
Merged
xiangao1
merged 7 commits into
generalize-objects
from
adapt-new-prescient-plugin-system
Aug 26, 2021
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f253d2a
register functions using context
xiangao1 d100947
comment out traceback and run-deterministic-ruc
xiangao1 e5ce5b0
remove outdated customized command line options
xiangao1 406facd
register customized commandline options using pyomo config
xiangao1 bf2d630
store plugin config as property
xiangao1 d1c10a6
using prescient python api
xiangao1 0e66048
remove the txt config file
xiangao1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plugin_config.bidding_generator
-- I would refactor this class slightly and store theplugin_config
passed intoregister_plugins
somewhere. You probably also don't need the_register_*_callbacks
methods anymore.The
declare_as_argument
method just has to do with how the command line option is created. Using thekey
in the name is optional.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ben! I just pushed a small change to store the
plugin_config
as a property. I think I should get rid of thebidding_generator
option, because thecoordinator
should get this information from bothbidder
andtracker
.The
_register_*_callbacks
methods make it a little easier for me to manage the plugin functions, in case we have more than one callbacks at some plugin points.