This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Add read_parquet #95
Merged
Add read_parquet #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
==========================================
+ Coverage 87.7% 88.08% +0.38%
==========================================
Files 17 19 +2
Lines 1895 1939 +44
==========================================
+ Hits 1662 1708 +46
+ Misses 233 231 -2
Continue to review full report at Codecov.
|
|
Depends on pandas-dev/pandas#30842 |
fjetter
reviewed
Jan 9, 2020
fletcher/base.py
Outdated
| @@ -637,6 +641,9 @@ def __getitem__(self, item): | |||
| For a boolean mask, return an instance of ``ExtensionArray``, filtered | |||
| to the values where ``item`` is True. | |||
| """ | |||
| if PANDAS_GE_0_26_0 and is_bool_dtype(item): | |||
| check_bool_array_indexer(self, item) | |||
There was a problem hiding this comment.
See pandas-dev/pandas#30308. It is checking nullable boolean arrays for NAs (and raise if there are), and return a numpy array.
So, actually, this needs to re-assign to item.
fjetter
approved these changes
Jan 9, 2020
Co-Authored-By: Joris Van den Bossche <[email protected]>
Co-Authored-By: Joris Van den Bossche <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.