Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak PersistenceProvider types #3896

Merged

Conversation

ghsolomon
Copy link
Contributor

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required.
  • Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile, or determined not required.
  • Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

Copy link
Member

@amcclain amcclain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ghsolomon ghsolomon force-pushed the registerPersistenceProviderTypes branch from 2a43d2e to 9c63a13 Compare January 13, 2025 22:51
@lbwexler lbwexler merged commit 5624969 into registerPersistenceProvider Jan 14, 2025
@lbwexler lbwexler deleted the registerPersistenceProviderTypes branch January 14, 2025 18:19
lbwexler added a commit that referenced this pull request Jan 14, 2025
* Add `PersistenceProvider.registerType` to support app-provided provider classes

* Add `PersistenceProviderType` union type, support app-level extension

- Remove exotic typing construct within create() impl in favor of simpler assertion
- Changelog entry

* Type tweak

* Tweak PersistenceProvider types (#3896)

* Checkpoint

* Checkpoint

* Checkpoint

---------

Co-authored-by: Anselm McClain <[email protected]>
Co-authored-by: Greg Solomon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants