Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi instance compare2 #3886

Merged
merged 3 commits into from
Jan 3, 2025
Merged

Conversation

lbwexler
Copy link
Member

@lbwexler lbwexler commented Jan 3, 2025

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required.
  • Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile, or determined not required.
  • Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

@lbwexler lbwexler changed the base branch from develop to multiInstanceCompare January 3, 2025 23:44
@lbwexler lbwexler merged commit 51bf50d into multiInstanceCompare Jan 3, 2025
1 check passed
@lbwexler lbwexler deleted the multiInstanceCompare2 branch January 3, 2025 23:45
lbwexler added a commit that referenced this pull request Jan 5, 2025
…n instances (#3851)

* Fixed grouping name for Hibernate Cache objs

* Renamed HzObjectAdminController to DistributedObjectAdminController

* WIP on admin tab

* WIP on admin tab

* WIP on admin tab

* WIP on admin tab

* WIP on admin tab

* Merged old distributed objects tab with new changes

* WIP work

* Bug fixes and name standardization

* UI/filtering enhancements

* UI/filtering enhancements

* UI/filtering enhancements

* Updated CHANGELOG.md

* Added error handling, comparing objects

* Moved DistributedObjects to a 2nd level tab

* Added non-comparison fields to detail grid

* Polish for the dist object page

* Code review changes

* NPE fix

* Fixed bug where check grid details were occasionally stale

* UI changes and fixes

- Moved and resized the details grid
- Renamed some UI elements
- Now uses diff icon
- Fixed TODO in tree grid contruction code

* Multi instance compare2 (#3886)

CR: Jakub

* Renames on FE

* Misc. UI/Code tweaks

* Further UI tweaks

* Further UI tweaks

* Further UI tweaks

---------

Co-authored-by: lbwexler <[email protected]>
Co-authored-by: Anselm McClain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant