Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Grid column filter UI lazy #3873

Merged
merged 3 commits into from
Dec 27, 2024
Merged

Make Grid column filter UI lazy #3873

merged 3 commits into from
Dec 27, 2024

Conversation

lbwexler
Copy link
Member

@lbwexler lbwexler commented Dec 26, 2024

Fixes mysterious bug. #3833

Could have figured out what the problem was, but noticed only manifesting on "stale" copies of the filter that had previously been mounted.

Was surprised that these models were still being created from the get go, although I know we discussed. Making this disposable is more efficient, lightweight, and easier to reason about.

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required.
  • Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile, or determined not required.
  • Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

+ Fixes mysterious bug.
+ More efficient, lightweight.
@lbwexler lbwexler requested a review from TomTirapani December 26, 2024 20:52
@lbwexler lbwexler linked an issue Dec 26, 2024 that may be closed by this pull request
@TomTirapani
Copy link
Member

Looks good and works well - fixed a small issue with a broken import and left over logging. 100% agree that it makes sense to recreate the state when the popover is opened, much easier to reason about 👍

@lbwexler lbwexler merged commit 24c7fbd into develop Dec 27, 2024
2 checks passed
@lbwexler lbwexler deleted the lazyColumnFilter branch December 27, 2024 14:28
@amcclain amcclain changed the title Make Column Filter UI lazy. Make Grid column filter UI lazy Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grid Filter is wrongly cleared when the Grid itself is cleared
2 participants