Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid spurious model lookup context changes #3518

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Conversation

lbwexler
Copy link
Member

@lbwexler lbwexler commented Nov 3, 2023

Thanks to Colin for finding this problem.

useContext will force a re-render whenever it value changes -- we were changing the object reference of our ModelLookup object every time we rendered it, leading to a cascade of spurious re-renders throughout the hierarchy below.

Think the not-so recent (oct. 2022) changes to TabContainer to include a RefereshContext exacerbated this problem such that components on hidden tabs were also re-rendering on tab switch.

To see the effect of this change, simply put a console log statement in any render method within a tab and start switching tabs in the tab container.

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required.
  • Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile, or determined not required.
  • Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

@lbwexler lbwexler requested review from amcclain and cnrudd November 3, 2023 01:08
@lbwexler lbwexler merged commit d6ab183 into develop Nov 3, 2023
2 checks passed
@lbwexler lbwexler deleted the cacheModelLookup branch November 3, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants