Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return from async functions not include additions to Promise prototype in Edge browser #1411

Closed
amcclain opened this issue Oct 16, 2019 · 2 comments
Closed

Return from async functions not include additions to Promise prototype in Edge browser #1411

amcclain opened this issue Oct 16, 2019 · 2 comments
Assignees
@amcclain
Labels
bug

Comments

@amcclain
Copy link
Member

Load up Toolbox in Edge and attempt to login - nothing happens when login clicked, console shows error Object doesn't support property or method thenAction. Same error will then occur with calls to Promise.timeout and the entire app is in a pretty weird state (as you would expect).
@amcclain amcclain added the bug label Oct 16, 2019
@amcclain amcclain changed the title Edge browser does not recognize additions to Promise prototype Return from fetchJson() does not include additions to Promise prototype in Edge browser Oct 16, 2019
@amcclain
Copy link
Member Author

See zloirock/core-js#178 which describes the issue. In Edge the return of json() is not wrapped and does not return our polyfilled/enhanced Promise as expected.

amcclain added a commit that referenced this issue Oct 16, 2019
@amcclain
Check to ensure json() return is a real Promise
8887c1d 
+ Fixes #1411 - bad break specific to MS Edge browser
+ Use shared typedef to get better docs / hinting on delegate methods.
@amcclain
Copy link
Member Author

Not fixed yet.....

Investigating 🔎

@amcclain amcclain reopened this Oct 17, 2019
@amcclain amcclain self-assigned this Oct 17, 2019
@amcclain amcclain changed the title Return from fetchJson() does not include additions to Promise prototype in Edge browser Return from async functions not include additions to Promise prototype in Edge browser Oct 17, 2019
amcclain added a commit that referenced this issue Oct 18, 2019
@amcclain
Install Hoist extensions on both "real" and Edge "native" Promises
a354044 
+ Fixes #1411 - maybe for real this time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amcclain amcclain

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amcclain @lbwexler