Skip to content

Commit

Permalink
Fix bug where a user could be prompted to log in to an app with SSO e… (
Browse files Browse the repository at this point in the history
#3521)

Fix bug where a user could be prompted to log in to an app with SSO enabled
  • Loading branch information
ghsolomon authored Nov 10, 2023
1 parent 5d7b4c1 commit d7d8ece
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 1 deletion.
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Changelog

## 59.3.1 - unreleased

### 🐞 Bug Fixes

* Ensure an unauthorized response from a proxy service endpoint does not prompt the user to refresh
and log in again on an SSO-enabled application.
* Revert change to `Panel` which affected where `className` was applied with `modalSupport` enabled

## 59.3.0 - 2023-11-09

### 🎁 New Features
Expand Down
1 change: 1 addition & 0 deletions core/exception/ExceptionHandler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,7 @@ export class ExceptionHandler {
// Detect an expired server session for special messaging, but only for requests back to the
// app's own server on a relative URL (to avoid triggering w/auth failures on remote CORS URLs).
private sessionExpired(e: HoistException): boolean {
if (XH.appSpec.isSSO) return false;
const {httpStatus, fetchOptions} = e,
relativeRequest = !fetchOptions?.url?.startsWith('http');

Expand Down
2 changes: 1 addition & 1 deletion desktop/appcontainer/ExceptionDialog.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,5 +90,5 @@ export const dismissButton = hoistCmp.factory<ExceptionDialogModel>(({model}) =>
});

function isSessionExpired(e) {
return e?.httpStatus === 401;
return !XH.appSpec.isSSO && e?.httpStatus === 401;
}

0 comments on commit d7d8ece

Please sign in to comment.