Fix bug in DockContainer where adding / removing views would cause …

…other views to be remounted (#3493) Co-authored-by: Lee Wexler <[email protected]>
xh · Oct 10, 2023 · cee4e75 · cee4e75
1 parent a92f039
commit cee4e75
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,7 @@
 * `DashContainerModel` fixes:
   * Fix bug where `addView` would throw when adding a view to a row or column
   * Fix bug where `allowRemove` flag was dropped from state for containers
+  * Fix bug in `DockContainer` where adding / removing views would cause other views to be remounted
 * Fix erroneous `GridModel` warning when using a tree column within a column group
 * Fix regression to alert banners. Resume allowing elements as messages
 

diff --git a/desktop/cmp/dock/impl/DockContainer.ts b/desktop/cmp/dock/impl/DockContainer.ts
@@ -25,6 +25,7 @@ export function dockContainerImpl(
         className: classNames(className, `xh-dock-container--${model.direction}`),
         items: model.views.map(viewModel => {
             return dockView({
+                key: viewModel.xhId,
                 model: viewModel,
                 compactHeaders
             });