Skip to content

Commit

Permalink
Fix max-height constraint on mobile menu (#3491)
Browse files Browse the repository at this point in the history
  • Loading branch information
TomTirapani authored Oct 10, 2023
1 parent f9b4570 commit bc6ff3f
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion mobile/cmp/menu/impl/Menu.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,13 @@
position: fixed;
margin: 0 !important;
z-index: 21;
max-height: 90vh;
/**
* Use `svh` units target the *smallest* viewport height, which is preferred to using `vh` on mobile.
* Including `px` units as a fallback for older browsers that may not support `vh`/`svh` units.
* https://css-tricks.com/the-large-small-and-dynamic-viewports/
*/
max-height: 500px;
max-height: 80svh;

&__title {
padding: var(--xh-pad-half-px);
Expand Down

0 comments on commit bc6ff3f

Please sign in to comment.