Hoist role support #309
Merged
Hoist role support #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add docs to roleService `init` function that cleans and builds database - clarify abiguity of multiple reasons, suggest possible alternatives
- provides a warning of the possible impact of changes - sends the timestamp of said warning to the client, expects to receive it back on update/delete to evaluate staleness
…move leftover TODO
This was
linked to
issues
Dec 22, 2023
lbwexler
commented
Dec 22, 2023
+ Move auth protection to controller + Remove spurious reference to "HOIST_ADMIN" + Support for adding default roles to a user + minor syntax improvements, hide private class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server-side changes to support xh/hoist-react#3447