Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add adjacency tensor function #664

Merged
merged 9 commits into from
Feb 13, 2025
Merged

Add adjacency tensor function #664

merged 9 commits into from
Feb 13, 2025

Conversation

maximelucas
Copy link
Collaborator

The function does not have a sparse option like the other matrix functions, because scipy.sparse has no implementation for sparse tensors (only 2d arrays). Potential candidate for later: the sparse library, but it does not have the equivalent of the csr_array that we usually use.

@maximelucas maximelucas marked this pull request as ready for review February 11, 2025 14:53
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.53%. Comparing base (18de14b) to head (0614169).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #664      +/-   ##
==========================================
+ Coverage   93.50%   93.53%   +0.02%     
==========================================
  Files          64       64              
  Lines        5005     5028      +23     
==========================================
+ Hits         4680     4703      +23     
  Misses        325      325              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maximelucas maximelucas requested a review from nwlandry February 12, 2025 10:29
xgi/linalg/hypergraph_matrix.py Show resolved Hide resolved
xgi/linalg/hypergraph_matrix.py Outdated Show resolved Hide resolved
xgi/linalg/hypergraph_matrix.py Outdated Show resolved Hide resolved
@maximelucas
Copy link
Collaborator Author

@nwlandry I think I addressed your comments!

Copy link
Collaborator

@nwlandry nwlandry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @maximelucas! Thanks so much!

@maximelucas maximelucas merged commit a365243 into main Feb 13, 2025
17 checks passed
@maximelucas maximelucas deleted the add_tensors branch February 13, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants