-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add adjacency tensor function #664
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #664 +/- ##
==========================================
+ Coverage 93.50% 93.53% +0.02%
==========================================
Files 64 64
Lines 5005 5028 +23
==========================================
+ Hits 4680 4703 +23
Misses 325 325 ☔ View full report in Codecov by Sentry. |
@nwlandry I think I addressed your comments! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, @maximelucas! Thanks so much!
The function does not have a
sparse
option like the other matrix functions, becausescipy.sparse
has no implementation for sparse tensors (only 2d arrays). Potential candidate for later: the sparse library, but it does not have the equivalent of thecsr_array
that we usually use.