-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow empty edges #565
Allow empty edges #565
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #565 +/- ##
=========================================
+ Coverage 0 92.82% +92.82%
=========================================
Files 0 59 +59
Lines 0 4348 +4348
=========================================
+ Hits 0 4036 +4036
- Misses 0 312 +312 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
@tlarock and @thomasrobiglio --- let me know if you have the bandwidth to review this. The URL workflow fails, but this is corrected in an already-merged PR. |
Hi @nwlandry, thank you for this. I am offline for these two weeks, I will review once I'm back. |
Enjoy your vacation! That sounds good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to make sure docstrings match function signatures re: default behaviors. Once that is done, good to go.
@thomasrobiglio --- are you still able to review this? No worries if not! |
This PR enables empty edges. This has long been an inconsistency, since
add_edges_from
allowed empty edges and, for example,dual
could create empty edges. This PR does the following:add_edge
methods inHypergraph
andDiHypergraph
and fromadd_simplex
inSimplicialComplex
.allow_empty
keyword in theremove_node
methods to handle discarding empty edges created from weakly removing nodes.remove_node
accessible as options in theremove_nodes_from
methods for consistency.This fixes #403.