Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added recipes for flagged triangular lattices and avg. shortest path length #513

Merged
merged 4 commits into from
Mar 3, 2024

Conversation

thomasrobiglio
Copy link
Collaborator

related to #504

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@thomasrobiglio thomasrobiglio linked an issue Feb 29, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.05%. Comparing base (3b92c02) to head (fb941ce).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #513      +/-   ##
==========================================
+ Coverage   92.03%   92.05%   +0.01%     
==========================================
  Files          60       60              
  Lines        4369     4378       +9     
==========================================
+ Hits         4021     4030       +9     
  Misses        348      348              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomasrobiglio thomasrobiglio changed the title Added recipe for flagged triangular lattices Added recipes for flagged triangular lattices and avg. shortest path length Feb 29, 2024
@thomasrobiglio
Copy link
Collaborator Author

Also added the recipe suggested in #511

@thomasrobiglio thomasrobiglio linked an issue Feb 29, 2024 that may be closed by this pull request
@@ -85,7 +85,7 @@
"outputs": [
Copy link
Collaborator

@nwlandry nwlandry Mar 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"length" not "lenght", "an" not "and", "remove length-0 paths" not "remove lengths 0". The last sentence is a bit confusing to read.


Reply via ReviewNB

@@ -85,7 +85,7 @@
"outputs": [
Copy link
Collaborator

@nwlandry nwlandry Mar 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #17.    avg_shortest_path = np.sum(lens) / (N * (N-1))

Where is N defined?


Reply via ReviewNB

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the recipe should be self-contained.

@nwlandry
Copy link
Collaborator

nwlandry commented Mar 2, 2024

Overall, looks good @thomasrobiglio! Nice work! Just a few minor comments to fix and I will approve so that you can merge.

@thomasrobiglio
Copy link
Collaborator Author

Thank you @nwlandry, I might have been a bit tired when I did the commits :)

@thomasrobiglio thomasrobiglio merged commit faacbfe into xgi-org:main Mar 3, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

how to calculate the average path length? Flagged lattices?
2 participants