-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added recipes for flagged triangular lattices and avg. shortest path length #513
Added recipes for flagged triangular lattices and avg. shortest path length #513
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #513 +/- ##
==========================================
+ Coverage 92.03% 92.05% +0.01%
==========================================
Files 60 60
Lines 4369 4378 +9
==========================================
+ Hits 4021 4030 +9
Misses 348 348 ☔ View full report in Codecov by Sentry. |
Also added the recipe suggested in #511 |
@@ -85,7 +85,7 @@ | |||
"outputs": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"length" not "lenght", "an" not "and", "remove length-0 paths" not "remove lengths 0". The last sentence is a bit confusing to read.
Reply via ReviewNB
@@ -85,7 +85,7 @@ | |||
"outputs": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like the recipe should be self-contained.
Overall, looks good @thomasrobiglio! Nice work! Just a few minor comments to fix and I will approve so that you can merge. |
Thank you @nwlandry, I might have been a bit tired when I did the commits :) |
related to #504