Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create check-urls.yml #498

Merged
merged 5 commits into from
Dec 4, 2023
Merged

Create check-urls.yml #498

merged 5 commits into from
Dec 4, 2023

Conversation

nwlandry
Copy link
Collaborator

@nwlandry nwlandry commented Dec 3, 2023

Added a Github Action to check URLs.

Copy link

codecov bot commented Dec 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (15208bc) 92.03% compared to head (e06e2e3) 92.03%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #498   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files          60       60           
  Lines        4369     4369           
=======================================
  Hits         4021     4021           
  Misses        348      348           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nwlandry nwlandry linked an issue Dec 3, 2023 that may be closed by this pull request
@nwlandry nwlandry marked this pull request as ready for review December 3, 2023 15:41
@maximelucas
Copy link
Collaborator

This amazing, thanks Nich!!
How do we know it works?
How does it work? For each PR it's gonna tell us if some urls are broken?

@nwlandry
Copy link
Collaborator Author

nwlandry commented Dec 4, 2023

This amazing, thanks Nich!! How do we know it works? How does it work? For each PR it's gonna tell us if some urls are broken?

That's exactly right. For instance, I already fixed a link because of this failed run: https://github.com/xgi-org/xgi/actions/runs/7077776967

@maximelucas
Copy link
Collaborator

Great then I'll approve. Does this mean all other urls work fine? Or we'll see at the next PR?

@nwlandry
Copy link
Collaborator Author

nwlandry commented Dec 4, 2023

Great then I'll approve. Does this mean all other urls work fine? Or we'll see at the next PR?

I think that if I'm correct, the link that I fixed was the only issue. And to correct what I said, the action is triggered with every push.

@nwlandry nwlandry merged commit 3b92c02 into main Dec 4, 2023
23 checks passed
@nwlandry nwlandry deleted the url-checker branch December 4, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible Github Action
2 participants