-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added cleanup method to all classes #440
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #440 +/- ##
==========================================
+ Coverage 90.94% 91.83% +0.89%
==========================================
Files 59 60 +1
Lines 4076 4251 +175
==========================================
+ Hits 3707 3904 +197
+ Misses 369 347 -22
☔ View full report in Codecov by Sentry. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Thanks Nich, looks good. Good idea this It's a bit long so I didn't check every single line. Just a few comments. |
I agree - my goal is to get things working and then we can focus on inheritance/sharing functionality. One of the issues that I ran into was that because |
Thanks for the explanations, looks good :) |
Thanks for the review, @maximelucas!! I appreciate it :) |
Fixes #195.
This PR
cleanup()
method toSimplicialComplex
andDiHypergraph
and fixes several bugs in thecleanup()
method forHypergraph
.isolates()
method to theDiNodeView
class.connected
kwarg tocleanup()
for hypergraphs and simplicial complexes, which removes nodes/edges not in the largest component.is_frozen
is now a property.