-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the _color_arg_to_dict function #402
Conversation
MVP!!!!! Thanks so much, @thomasrobiglio. That was the issue. I'll add a couple of tests and then undraft this PR. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #402 +/- ##
==========================================
- Coverage 90.94% 90.90% -0.04%
==========================================
Files 47 47
Lines 3888 3916 +28
==========================================
+ Hits 3536 3560 +24
- Misses 352 356 +4
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good :)
minval = 0.1 | ||
maxval = 0.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how are these decided?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These values are so that the colors don't fade into the background but I suppose we could add them as an arg in the future?
Nice good job! Just a few questions to make sure the docs are clear. Btw: do you think we have similar problems (cmap/sizes not used from list) in _scalar_to_dict? |
I updated |
This fixes #389.