-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update index.rst to have dihypergraph in quick references #392
update index.rst to have dihypergraph in quick references #392
Conversation
I saw it too but not sure we want it there since it's still experimental? |
Good point Max |
Ah right, I did not think about that |
@thomasrobiglio you were right - you can check the documentation built from this PR (instead of from the main branch) by clicking "docs/readthedocs.orx:xgi" under the "all checks have passed" button here in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good idea. While this is still an experimental feature, perhaps you can just add (Experimental feature!) or something like that after the text, so that users can still easily find it if they want to use it.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #392 +/- ##
=======================================
Coverage 91.02% 91.02%
=======================================
Files 47 47
Lines 3878 3878
=======================================
Hits 3530 3530
Misses 348 348 ☔ View full report in Codecov by Sentry. |
Now it will appear like this... but maybe this is not what you had in mind @nwlandry (since also there was already the warning in the class docs). Then of course we can change the text, this one was co-authored by copilot :) |
I like the warning admonition. I would delete the middle sentence and leave the first and last. |
Looks great! I agree with Leo on deleting the middle sentence and then I think you're good to merge, @thomasrobiglio. Thanks so much! |
I noticed that the DH does not appear in the quick references, I think this might fix it (but I'm not familiar at all with how Sphinx works, etc. so pls check it).