-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster flag complex #355
Faster flag complex #355
Conversation
…sts: moved for consistency and added corresponding
(The new commits are the last two, not sure why the others appear here, I think they're from a past PR) |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #355 +/- ##
==========================================
- Coverage 90.55% 90.51% -0.04%
==========================================
Files 41 41
Lines 3016 3025 +9
==========================================
+ Hits 2731 2738 +7
- Misses 285 287 +2
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:)
Thanks Leo! Should all be addressed. |
…ions/xgi into faster-flag-complex
Adresses #264
flag_complex
andrandom_flag_complex
were computing all maximal cliques and then lettingadd_simplices_from
dealing with themax_order
parameter.This means that a small network with large density was already very long to compute, e.g.
I changed this: only cliques up to
max_order
are computed and then passed toadd_simplices_from
.Roughly a 100x speedup, expected to be more for larger and denser graphs.
I also added some tests because the ones we had were testing consistency but not correctness.