Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up classes #353

Merged
merged 4 commits into from
May 6, 2023
Merged

Clean up classes #353

merged 4 commits into from
May 6, 2023

Conversation

nwlandry
Copy link
Collaborator

@nwlandry nwlandry commented May 5, 2023

  • Moved IDDict to utilities to prepare for the DiHypergraph class
  • Removed unnecessary arguments in the constructor of IDView

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Patch coverage: 93.02% and project coverage change: +0.11 🎉

Comparison is base (591d681) 90.43% compared to head (c2a454e) 90.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #353      +/-   ##
==========================================
+ Coverage   90.43%   90.55%   +0.11%     
==========================================
  Files          41       41              
  Lines        3012     3016       +4     
==========================================
+ Hits         2724     2731       +7     
+ Misses        288      285       -3     
Impacted Files Coverage Δ
xgi/classes/reportviews.py 93.61% <85.00%> (+1.72%) ⬆️
xgi/classes/hypergraph.py 85.37% <100.00%> (-0.66%) ⬇️
xgi/convert.py 95.61% <100.00%> (ø)
xgi/utils/utilities.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@leotrs leotrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad the awful View constructor was cleaned up!

@nwlandry nwlandry merged commit a58a4b8 into main May 6, 2023
@nwlandry nwlandry deleted the clean-up-classes branch May 20, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants