Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added trivial hypergraph #335

Merged
merged 4 commits into from
Apr 14, 2023
Merged

feat: added trivial hypergraph #335

merged 4 commits into from
Apr 14, 2023

Conversation

maximelucas
Copy link
Collaborator

No description provided.

xgi/generators/classic.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (b42a04f) 90.29% compared to head (23219c1) 90.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
+ Coverage   90.29%   90.32%   +0.02%     
==========================================
  Files          41       41              
  Lines        2958     2966       +8     
==========================================
+ Hits         2671     2679       +8     
  Misses        287      287              
Impacted Files Coverage Δ
xgi/generators/classic.py 96.29% <100.00%> (+1.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maximelucas
Copy link
Collaborator Author

More general question: our current implementation of empy_hypergraph looks more complicated than it could.
Could it not just be xgi.Hypergraph().
Any thoughts?

xgi/generators/classic.py Outdated Show resolved Hide resolved
xgi/generators/classic.py Show resolved Hide resolved
@maximelucas maximelucas merged commit 112defd into main Apr 14, 2023
@maximelucas maximelucas deleted the classic branch April 14, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants