Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index-to-unit mappings from to_bipartite_graph. Fixes #322 #323

Merged
merged 2 commits into from
Apr 5, 2023
Merged

Conversation

leotrs
Copy link
Collaborator

@leotrs leotrs commented Apr 5, 2023

The default has been set to False to mirror the behavior of linalg. Fixes #322.

… The default has been set to False to mirror the behavior of linalg.
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.09 ⚠️

Comparison is base (f453fdd) 90.25% compared to head (53d501a) 90.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #323      +/-   ##
==========================================
- Coverage   90.25%   90.17%   -0.09%     
==========================================
  Files          35       35              
  Lines        2813     2869      +56     
==========================================
+ Hits         2539     2587      +48     
- Misses        274      282       +8     
Impacted Files Coverage Δ
xgi/convert.py 95.67% <100.00%> (+0.04%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maximelucas
Copy link
Collaborator

Look good thanks Leo!
Maybe just add one line to test the index=False case?

@leotrs
Copy link
Collaborator Author

leotrs commented Apr 5, 2023

Thanks @maximelucas I added the test.

@leotrs leotrs merged commit ca4fb51 into main Apr 5, 2023
@maximelucas maximelucas deleted the fix-322 branch April 5, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

to_bipartite_graph documented return type is incorrect
2 participants