Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup drawing #173

Merged
merged 4 commits into from
Sep 21, 2022
Merged

Speedup drawing #173

merged 4 commits into from
Sep 21, 2022

Conversation

nwlandry
Copy link
Collaborator

Attempted to make xgi.draw() a bit faster.

Copy link
Collaborator

@leotrs leotrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, do you know how much faster this is?

@nwlandry
Copy link
Collaborator Author

nwlandry commented Sep 21, 2022

Out of curiosity, do you know how much faster this is?

Tested on the email-enron dataset (after cleanup() with default arguments) for the edges and the size EdgeStat:
_color_arg_to_dict (old): 3.08 s ± 290 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)
_color_arg_to_dict (new): 119 ms ± 9.86 ms per loop (mean ± std. dev. of 7 runs, 10 loops each)
_scalar_arg_to_dict (old): 2.74 s ± 294 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)
_scalar_arg_to_dict (new): 3.19 ms ± 74.5 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)

@nwlandry nwlandry merged commit c262f40 into main Sep 21, 2022
@nwlandry nwlandry deleted the speedup-drawing branch September 21, 2022 15:58
@leotrs
Copy link
Collaborator

leotrs commented Sep 21, 2022

So a 1000x speedup???? Jeez.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants