Cleanup method #161
Merged
Cleanup method #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leotrs
requested changes
Aug 31, 2022
There was a problem hiding this comment.
Thanks for this! BTW, does this depend on #162?
Also, should we add a parameter in_place? If in_place is False, then a new hypergraph is returned and the original one is left intact. This might simplify some of the code inside the if reindex: branch.
Merged
nwlandry
force-pushed
the
cleanup-method
branch
from
a7fc9b5 to
639c2ff
Compare
|
Pro tip: next time try rebasing your PR rather than merging main into it bc it makes it hard to review. The current diff shows both changes from this PR as well as the other one. If rebasing does not work/is scary, you can also just close it and start a new PR. |
leotrs
approved these changes
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
duplicates()method to not include the first instance of the node/edge in the list of duplicates, so that when you callH.remove_edges_from(H.edges.duplicates())it only removes the redundant edges, not all of the edges. In preparation of only supporting non-loopy edges, theduplicates()method has been simplified to not differentiate between duplicate nodes in an edge.