-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 138: allow xgi.draw to set color of individual nodes or edges #139
Conversation
This works, yes. However, it still gives problem when you pass an array because the access for arrays is also through node id and not through node position. |
How about accepting a list or array and mapping indices to nodes like this? (In addition to the dictionary and string methods)
a more succinct way to do that would be |
Wait actually I think I misunderstood what you said. You mean accepting an array like @mcontisc is suggesting, and assuming the order of the colors in the array is the same as the node-addition order, correct? In that case, then yes that's what I was thinking. |
Done! Now |
Yes, I agree :) Thanks a lot! |
For now, yes. It would be nice to have a way to override the color assigned to a hyperedge via some other parameter, cc @iaciac. |
Looks great!! I think it's ready to merge! I can add the coloring individual edges as an issue. |
See #138. Also see attached image, ran from this branch.