-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove np random generators for memory reasons #361
Labels
good first issue
Good for newcomers
Comments
You can also chain a generator of np.randoms of a few millions or so to potentially get the best of both worlds. |
Merged
nwlandry
added a commit
that referenced
this issue
Oct 16, 2024
* Add ability to generate ER hypergraphs without multiedges * update * Remove bad characters * Fix #361 * Revert "Fix #361" This reverts commit 28cbbf3. * Fix #361 * Update test.yml * fix non-multi-edge probability * formatting * Update random.py * Update xgi/generators/uniform.py Co-authored-by: Maxime Lucas <[email protected]> * Update using-xgi.rst * Response to review * Update uniform.py * Update xgi/generators/random.py Co-authored-by: Maxime Lucas <[email protected]> * Update xgi/generators/random.py Co-authored-by: Maxime Lucas <[email protected]> * Update xgi/generators/uniform.py Co-authored-by: Maxime Lucas <[email protected]> * Update xgi/generators/uniform.py Co-authored-by: Maxime Lucas <[email protected]> * Update xgi/generators/uniform.py Co-authored-by: Maxime Lucas <[email protected]> * Update xgi/generators/uniform.py Co-authored-by: Maxime Lucas <[email protected]> * Update xgi/generators/uniform.py Co-authored-by: Maxime Lucas <[email protected]> * Update xgi/generators/uniform.py Co-authored-by: Maxime Lucas <[email protected]> * updates * Conditional API note (#595) * Conditional API note * Update api_reference.rst * Remove bad characters * Update random.py * Update xgi/generators/random.py Co-authored-by: Maxime Lucas <[email protected]> * Update xgi/generators/random.py Co-authored-by: Maxime Lucas <[email protected]> * response to review * updates * Update random.py * format * Update random.py * update docs * add unit tests * Fix test * test different version * fix test * updates * last additions * update * fix error * unnecessary import * add unit tests * Update xgi/generators/random.py Co-authored-by: Maxime Lucas <[email protected]> * Update xgi/generators/random.py Co-authored-by: Maxime Lucas <[email protected]> * Update xgi/generators/random.py Co-authored-by: Maxime Lucas <[email protected]> * Update xgi/generators/random.py Co-authored-by: Maxime Lucas <[email protected]> --------- Co-authored-by: Maxime Lucas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@maximelucas The combinatorial explosion of the mask array makes it impossible to use in some scenarios: e.g.
But that also has an easy solution of not pre-allocating mask:
This doesn't fail but this still takes$O({{N}\choose{m}})$ time to run.
Originally posted by @arashbm in #339 (comment)
Summary: go back to list comprehension rather than np.random()
The text was updated successfully, but these errors were encountered: