Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjustments for Elixir 1.11 #253

Merged
merged 10 commits into from
Jan 15, 2021
Merged

adjustments for Elixir 1.11 #253

merged 10 commits into from
Jan 15, 2021

Conversation

0xAX
Copy link
Member

@0xAX 0xAX commented Jun 23, 2020

No description provided.

@0xAX
Copy link
Member Author

0xAX commented Jun 23, 2020

@mbuhot can you please take a look

@0xAX 0xAX requested a review from mbuhot June 23, 2020 13:56
@0xAX
Copy link
Member Author

0xAX commented Jun 23, 2020

ah, I have just found devinus/poison#172, so updating to poison 4.0.x probably is not suitable here

@mbuhot
Copy link
Contributor

mbuhot commented Jun 23, 2020

Probably a good time to update the travis matrix: https://github.com/xerions/phoenix_swagger/blob/master/.travis.yml

@mbuhot
Copy link
Contributor

mbuhot commented Jun 24, 2020

@0xAX I've created #254 on top of this branch to update the example app with latest dependencies too.

@0xAX
Copy link
Member Author

0xAX commented Jun 24, 2020

@mbuhot thanks I will look

@0xAX
Copy link
Member Author

0xAX commented Jun 24, 2020

@mbuhot I've merged it. I will figure out how to be with poison and update this PR, so please do not merge it for now

@0xAX 0xAX force-pushed the elixir-1.10-adjustments branch from 3341a6f to 8de69a4 Compare January 14, 2021 17:17
@0xAX 0xAX changed the title adjustments for Elixir 1.10 adjustments for Elixir 1.11 Jan 14, 2021
@0xAX 0xAX force-pushed the elixir-1.10-adjustments branch from 8de69a4 to d181115 Compare January 14, 2021 17:47
@0xAX 0xAX force-pushed the elixir-1.10-adjustments branch from d181115 to 0a8c1a7 Compare January 15, 2021 08:37
@0xAX 0xAX force-pushed the elixir-1.10-adjustments branch from 0a8c1a7 to 4719b7b Compare January 15, 2021 08:45
@0xAX
Copy link
Member Author

0xAX commented Jan 15, 2021

It looks like poison is still not updated, I've tested it with jason and it works perfectly. Also I've updated CI to the more modern elixir versions. So I think this could be merged and phoenix_swagger 0.8.3 released.

@mbuhot can you please take a look.

Copy link
Contributor

@mbuhot mbuhot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good @0xAX

@0xAX
Copy link
Member Author

0xAX commented Jan 15, 2021

Pushed 0.8.3 tag and uploaded new version to hex.pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants