Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace URL.encode to be able to run both on ruby2/ruby3 #14

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Replace URL.encode to be able to run both on ruby2/ruby3 #14

merged 1 commit into from
Oct 28, 2022

Conversation

yuokada
Copy link
Collaborator

@yuokada yuokada commented Oct 28, 2022 •
edited
Loading

@yuokada yuokada changed the title Replace URL.encode to run both on ruby2/ruby3 Replace URL.encode to be able to run both on ruby2/ruby3 Oct 28, 2022
@yuokada yuokada marked this pull request as ready for review October 28, 2022 02:35
@yuokada yuokada requested review from takezoe and xerial October 28, 2022 02:49
takezoe
takezoe approved these changes Oct 28, 2022
View reviewed changes
Copy link
Collaborator

@takezoe takezoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@yuokada yuokada merged commit 72a4e0f into master Oct 28, 2022
@yuokada yuokada deleted the fix-url-encode branch October 28, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takezoe takezoe takezoe approved these changes

@xerial xerial Awaiting requested review from xerial

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuokada @takezoe