feat: add cobra cli #1
Conversation
Signed-off-by: Michael Fornaro <[email protected]>
Signed-off-by: Michael Fornaro <[email protected]>
main.go
Outdated
There was a problem hiding this comment.
Not sure if we need to have an empty main.go
There was a problem hiding this comment.
i think he deleted main.go
There was a problem hiding this comment.
weird, why it's not appears as deleted?
advisor/pkg/k8s/networkpolicies.go
Outdated
| @@ -17,6 +37,103 @@ type NetworkPolicySpec struct { | |||
| Egress []NetworkPolicyRule | |||
| } | |||
|
|
|||
| func GenerateNetworkPolicy(podName string) { | |||
There was a problem hiding this comment.
Do we need to support namespace as parameter?
There was a problem hiding this comment.
Yes, namespace is needed,
There was a problem hiding this comment.
Just do the kubectl way, using -n or --namespace flag to receive the value.
advisor/cmd/root.go
Outdated
There was a problem hiding this comment.
For future reference, it would be good to use genericclioptions to inherit some flags for example namespace, context and more
There was a problem hiding this comment.
This is a great idea - I'm going to merge this all in and it would be a great update
…e broker and more Signed-off-by: Michael Fornaro <[email protected]>
Signed-off-by: Michael Fornaro <[email protected]>
No description provided.