Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NyanCat v1.0.0 #46

Merged
merged 11 commits into from
Jul 29, 2020
Merged

Conversation

hazard999
Copy link
Member

First draft of a NyanCatReporter

Fixes #39

@biohazard999
Copy link
Contributor

To test out the reporter you need to register the reporter in Tasty and don't run the b command cause it launches 2 runs in parallel, cause we don't solved the register multiple reporters problem yet.

  public static class Tasty
    {
        static Tasty()
        {
            DefaultScope = new TastyScope();
            // ConsoleReporter.Register();
            NyanCatReporter.Register();
            DefaultScope.RegisterTransport(NamedPipeRemoteHook.CreateNamedPipeTransportStream);
        }

C:\F\git\Tasty\test\Xenial.Tasty.Tests

dotnet run -f netcoreapp3.1

@biohazard999
Copy link
Contributor

Currently the output of nyan is a little bit deformed :P

image

@hazard999
Copy link
Member Author

Currently the output of nyan is a little bit deformed :P

image

At least it nyans 🤷‍♂️😆

Copy link
Contributor

@biohazard999 biohazard999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hazard999 hazard999 changed the title NyanCat v0.0.1 NyanCat v0.1.0 Jul 28, 2020
@biohazard999
Copy link
Contributor

When running build locally it blows up on the integration tests with a HandleInvalid in the SetCursor.

For now we should be fine by logging out the exception to stdout in the ReportTestMiddleware

public static class ReportTestMiddleware
    {
        public static TestExecutor UseTestReporters(this TestExecutor executor)
            => executor.Use(async (context, next) =>
            {
                try
                {
                    await next();
                }
                finally
                {
                    try
                    {
                        await context.CurrentScope.Report(context.CurrentCase);
                    }
                    catch (Exception ex)
                    {
                        Console.WriteLine($"Reporter failed: {ex}");
                    }
                }
            });
    }

Copy link
Contributor

@biohazard999 biohazard999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It nyans! ( ^ .^)

image

Xenial.Tasty.v3.ncrunchsolution Outdated Show resolved Hide resolved
src/Xenial.Tasty/Xenial.Tasty.csproj Show resolved Hide resolved
src/Xenial.Tasty/Reporters/Reporters.NyanCat.cs Outdated Show resolved Hide resolved
src/Xenial.Tasty/Reporters/Reporters.NyanCat.cs Outdated Show resolved Hide resolved
src/Xenial.Tasty/Reporters/Reporters.NyanCat.cs Outdated Show resolved Hide resolved
src/Xenial.Tasty/Reporters/Reporters.NyanCat.cs Outdated Show resolved Hide resolved
src/Xenial.Tasty/Tasty.cs Outdated Show resolved Hide resolved
@biohazard999 biohazard999 mentioned this pull request Jul 29, 2020
@biohazard999
Copy link
Contributor

Besides the lacking summary reporter this looks awesome! Thanks @hazard999

@hazard999 hazard999 marked this pull request as ready for review July 29, 2020 13:35
@hazard999 hazard999 changed the title NyanCat v0.1.0 NyanCat v1.0.0 Jul 29, 2020
@biohazard999 biohazard999 merged commit ebef194 into xenial-io:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a nyancat reporter
3 participants