add new event #106
Merged
add new event #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xen0n
requested changes
Aug 27, 2022
rx_msg.go
Outdated
| @@ -181,3 +181,21 @@ func (m *RxMessage) EventChangeTypeCreateUser() (*rxEventChangeTypeCreateUser, b | |||
| y, ok := m.extras.(*rxEventChangeTypeCreateUser) | |||
| return y, ok | |||
| } | |||
|
|
|||
| // EventAppMenuClick 点击菜单事件 | |||
rx_msg.go
Outdated
|
|
||
| // EventUnknown 未定义的event类型 | ||
| func (m *RxMessage) EventUnknown() (*rxEventUnknow, bool) { | ||
| y, ok := m.extras.(*rxEventUnknow) |
rx_msg.md.go
Outdated
Comment on lines
64
to
82
| // 应用菜单事件 | ||
| const ( | ||
| // EventTypeAppMenuClick 点击菜单 | ||
| EventTypeAppMenuClick = "click" | ||
| // EventTypeAppMenuCView 打开菜单链接 | ||
| EventTypeAppMenuView = "view" | ||
| // EventTypeAppMenuScanCodePush 扫码上传 | ||
| EventTypeAppMenuScanCodePush = "scancode_push" | ||
| // EventTypeAppMenuScanCodeWaitMsg 扫码等待消息 | ||
| EventTypeAppMenuScanCodeWaitMsg = "scancode_waitmsg" | ||
| // EventTypeAppMenuPicSysPhoto 弹出系统拍照发图 | ||
| EventTypeAppMenuPicSysPhoto = "pic_sysphoto" | ||
| // EventTypeAppMenuPicPhotoOrAlbum 弹出系统拍照发图 | ||
| EventTypeAppMenuPicPhotoOrAlbum = "pic_photo_or_album" | ||
| // EventTypeAppMenuPicWeixin 弹出微信相册发图器 | ||
| EventTypeAppMenuPicWeixin = "pic_weixin" | ||
| // EventTypeAppMenuLocationSelect 弹出微信位置选择器 | ||
| EventTypeAppMenuLocationSelect = "location_select" | ||
| ) |
There was a problem hiding this comment.
你得改相应的 md 文件然后 go generate 吧，否则下次这些更改就没了
你在写这个文件的时候，编辑器应该警告你不要动它了，文件头也告诉你这个文件怎么生成的了。。。
|
thx! 大佬看的好认真，我下周改一下；确实没怎么看代码规范，也没看项目的代码逻辑，只想着实现我需要的功能了T.T |
|
Ping |
xen0n
reviewed
Sep 7, 2022
docs/rx_msg.md
Outdated
| const EventTypeAppSubscribe = "subscribe" | ||
|
|
||
| // EventTypeAppUnSubscribe 应用订阅取消 | ||
| const EventTypeAppUnSubscribe = "unsubscribe" |
|
改好之后，rebase（不允许有 merge 提交），squash 成单个提交，改提交说明 或者我帮你搞？ |
我弄吧， |
xen0n
reviewed
Sep 7, 2022
docs/rx_msg.md
Outdated
| const EventTypeAppUnsubscribe = "unsubscribe" | ||
|
|
||
| // EventTypeUnknown 未在本项目中定义与实现的event类型 | ||
| const EventTypeUnknown = ".*" |
There was a problem hiding this comment.
这个没用到吧。。实际上他也不会被当作正则来用（未知消息类型，直接看取到的值类型就知道他“未知”了），去掉就好了
|
虽然你的 commit message 里“3. 未知事件类型: sdk中未定义的事件类型, 返回原始的body, 用于debug”这里序号 3 重复了，但无伤大雅，先给你合了 bors r+ 十分感谢贡献！ |
xen0n
approved these changes
Sep 8, 2022
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
新增事件消息类型：
clickview