Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s/Env/Log/ #176

Merged
merged 2 commits into from
Feb 5, 2019
Merged

s/Env/Log/ #176

merged 2 commits into from
Feb 5, 2019

Conversation

purrgrammer
Copy link
Contributor

Closes #167

juanpedromoreno
juanpedromoreno approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Feb 5, 2019

Codecov Report

Merging #176 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #176   +/-   ##
=======================================
  Coverage   96.57%   96.57%           
=======================================
  Files           6        6           
  Lines         175      175           
  Branches        6        5    -1     
=======================================
  Hits          169      169           
  Misses          6        6
Impacted Files Coverage Δ
shared/src/main/scala/fetch.scala 96.79% <100%> (ø) ⬆️
shared/src/main/scala/log.scala 66.66% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02c3738...05d9f06. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 5, 2019 •
edited
Loading

Codecov Report

Merging #176 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #176   +/-   ##
=======================================
  Coverage   96.57%   96.57%           
=======================================
  Files           6        6           
  Lines         175      175           
  Branches        6        5    -1     
=======================================
  Hits          169      169           
  Misses          6        6
Impacted Files Coverage Δ
shared/src/main/scala/fetch.scala 96.79% <100%> (ø) ⬆️
shared/src/main/scala/log.scala 66.66% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02c3738...05d9f06. Read the comment docs.

@JorgeCastilloPrz
Copy link

@purrgrammer can you open the equivalent issue in Kollect so we don't forget?

@purrgrammer purrgrammer mentioned this pull request Feb 5, 2019
Open
@raulraja raulraja merged commit 4eb9abd into master Feb 5, 2019
@raulraja raulraja deleted the env-to-log branch February 5, 2019 16:58
bijancn pushed a commit to bijancn/fetch that referenced this pull request Sep 19, 2019
@purrgrammer @raulraja
s/Env/Log/ (xebia-functional#176)
5aa6bcc 
* s/Env/Log/

* Fix examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulraja raulraja raulraja approved these changes

@juanpedromoreno juanpedromoreno juanpedromoreno approved these changes

@diesalbla diesalbla Awaiting requested review from diesalbla

@peterneyens peterneyens Awaiting requested review from peterneyens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@purrgrammer @JorgeCastilloPrz @raulraja @juanpedromoreno