Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pricing basis for components #924

Merged
merged 17 commits into from
Mar 23, 2022

Conversation

marvin9257
Copy link
Collaborator

@marvin9257 marvin9257 commented Mar 17, 2022

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    feature

  • What is the current behavior? (You can also link to an open issue here)
    only way to price components is per unit
    can drag an drop roll tables as macros

  • What is the new behavior (if this is a feature change)?
    now provide more options: per unit, per ton, or % base hull
    ability to drag and drop roll table as macro

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Other information:
    also refactors from {{#select and {{#each to {{selectOptions on component sheet to leverage built in handlebar - bonus is that it adds localization

@marvin9257 marvin9257 changed the title WIP feat: add pricing basis for components feat: add pricing basis for components Mar 20, 2022
@marvin9257 marvin9257 linked an issue Mar 20, 2022 that may be closed by this pull request
@marvin9257 marvin9257 merged commit 5470666 into xdy:master Mar 23, 2022
@marvin9257 marvin9257 deleted the add-price-options-to-ship-components branch March 23, 2022 14:26
@github-actions
Copy link

🎉 This PR is included in version 1.27.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more stats to the ship actor
1 participant