-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add pricing basis for components #924
Merged
marvin9257
merged 17 commits into
xdy:master
from
marvin9257:add-price-options-to-ship-components
Mar 23, 2022
Merged
feat: add pricing basis for components #924
marvin9257
merged 17 commits into
xdy:master
from
marvin9257:add-price-options-to-ship-components
Mar 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix typo in comment
marvin9257
changed the title
WIP feat: add pricing basis for components
feat: add pricing basis for components
Mar 20, 2022
🎉 This PR is included in version 1.27.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
only way to price components is per unit
can drag an drop roll tables as macros
What is the new behavior (if this is a feature change)?
now provide more options: per unit, per ton, or % base hull
ability to drag and drop roll table as macro
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
also refactors from {{#select and {{#each to {{selectOptions on component sheet to leverage built in handlebar - bonus is that it adds localization