Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Big change to how rolling is performed. #299

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

xdy
Copy link
Owner

@xdy xdy commented Jan 8, 2021

Few user-visible changes other than rolls now showing Sum and Effect at the same time.

Fixes #86

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Removes setting for whether to show sum or effect on skill roll. Rebuilds dice rolling.

  • What is the current behavior? (You can also link to an open issue here)
    Shows either sum or effect.

  • What is the new behavior (if this is a feature change)?
    Shows both.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Other information:
    n/a

@xdy xdy force-pushed the pajon_refactor_no_untrained branch from 25496fd to abc9707 Compare January 8, 2021 12:58
@xdy xdy changed the title feat: Big change to how rolling is performed by @pajon and @xdy. feat: Big change to how rolling is performed. Jan 8, 2021
@xdy xdy force-pushed the pajon_refactor_no_untrained branch from 4ff9a01 to 69fae39 Compare January 8, 2021 13:04
Few user-visible changes other than rolls now showing Sum and Effect at the same time.

Fixes #86
@xdy xdy force-pushed the pajon_refactor_no_untrained branch from 8ff35ef to 95a6f48 Compare January 8, 2021 13:05
@xdy xdy merged commit f86bfcc into master Jan 8, 2021
@xdy xdy deleted the pajon_refactor_no_untrained branch January 8, 2021 13:13
@github-actions
Copy link

github-actions bot commented Jan 8, 2021

🎉 This PR is included in version 0.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@xdy xdy restored the pajon_refactor_no_untrained branch January 8, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rebuild dice rolling
2 participants