WIP feat: move to v13

package.json

@@ -75,6 +75,7 @@
     "last 3 versions"
   ],
   "dependencies": {
-    "@league-of-foundry-developers/foundry-vtt-types": "github:League-of-Foundry-Developers/foundry-vtt-types#2315d2385e256f8e7011667683f0859f1f769fdf"
+    "@league-of-foundry-developers/foundry-vtt-types": "github:League-of-Foundry-Developers/foundry-vtt-types#2315d2385e256f8e7011667683f0859f1f769fdf",
+    "latest-version": "^9.0.0"
   }
 }

src/migrations/2025_01_20_09_11_refactor_armorPiercing.ts

@@ -0,0 +1,25 @@
+// eslint-disable-next-line @typescript-eslint/ban-ts-comment
+// @ts-nocheck This turns off *all* typechecking, make sure to remove this once foundry-vtt-types are updated to cover v10.
+import { applyToAllItems, applyToAllActors } from "../module/utils/migration-utils";
+
+async function refactorArmorPiercing(item: TwodsixItem): Promise<void> {
+  if (foundry.utils.hasProperty(item.system, 'armorPiercing')) {
+    if (typeof item.system.armorPiercing === 'number') {
+      const newString = item.system.armorPiercing === 0 ? "0" : item.system.armorPiercing.toString();
+      await item.update({'system.armorPiercing': newString});
+    }
+  }
+}
+
+async function refactorItems (actor:TwodsixActor): Promise<void> {
+  for (const item of actor.items) {
+    await refactorArmorPiercing(item);
+  }
+}
+
+export async function migrate(): Promise<void> {
+  await applyToAllItems(refactorArmorPiercing);
+  await applyToAllActors(refactorItems);
+  console.log("Armor Piercing Migration Complete");
+  return Promise.resolve();
+}

src/module/data/commonSchemaUtils.ts

@@ -46,3 +46,17 @@ export function migrateStringToNumber(source:any, field:string):void {
     }
   }
 }
+
+/**
+ * Convert field from number to string.
+ * @param {any} source data source (document.system)
+ * @param {string} field  system field to convert.
+ * @returns {void}
+ */
+export function migrateNumberToString(source:any, field:string):void {
+  if ( Object.hasOwn(source, field)) {
+    if ( typeof source[field] !== 'string') {
+      source[field] = source[field].toString() || "0";
+    }
+  }
+}

src/module/data/item.ts

@@ -1,6 +1,6 @@
 // eslint-disable-next-line @typescript-eslint/ban-ts-comment
 // @ts-nocheck This turns off *all* typechecking, make sure to remove this once foundry-vtt-types are updated to cover v10.
-import { makeResourceField, makeValueField, migrateStringToNumber} from "./commonSchemaUtils";
+import { makeResourceField, makeValueField, migrateNumberToString, migrateStringToNumber} from "./commonSchemaUtils";
 import { GearData, makeTargetTemplate, TwodsixItemBaseData } from "./item-base";
 
 const fields = foundry.data.fields;
@@ -25,7 +25,7 @@ export class WeaponData extends GearData {
     schema.doubleTap = new fields.BooleanField({ required: true, initial: false});
     schema.recoil = new fields.BooleanField({ required: true, initial: false});
     schema.features = new fields.StringField({...requiredBlankString});
-    schema.armorPiercing = new fields.NumberField({...requiredInteger, initial: 0});
+    schema.armorPiercing = new fields.StringField({required: true, blank: false, initial: "0" });
     schema.parryAV = new fields.NumberField({...requiredInteger, initial: 0});
     schema.isShield = new fields.BooleanField({ required: true, initial: false});
     schema.handlingModifiers = new fields.StringField({...requiredBlankString});
@@ -61,6 +61,11 @@ export class WeaponData extends GearData {
         source.ammo = 0;
       }
     }
+    if ("armorPiercing" in source) {
+      if (typeof source.armorPiercing !== 'string') {
+        migrateNumberToString(source, 'armorPiercing');
+      }
+    }
     return super.migrateData(source);
   }
 }
@@ -153,7 +158,7 @@ export class ConsumableData extends GearData {
     schema.currentCount = new fields.NumberField({...requiredInteger, initial: 1});
     schema.max = new fields.NumberField({...requiredInteger, initial: 0});
     schema.subtype = new fields.StringField({required: true, blank: false, initial: "other" });
-    schema.armorPiercing = new fields.NumberField({...requiredInteger, initial: 0});
+    schema.armorPiercing = new fields.StringField({required: true, blank: false, initial: "0" });
     schema.bonusDamage = new fields.StringField({...requiredBlankString});
     schema.ammoRangeModifier = new fields.StringField({required: true, blank: false, initial: "0" });
     schema.isAttachment = new fields.BooleanField({ required: true, initial: false});
@@ -171,6 +176,11 @@ export class ConsumableData extends GearData {
         source.ammoRangeModifier = "0";
       }
     }
+    if ("armorPiercing" in source) {
+      if (typeof source.armorPiercing !== 'string') {
+        migrateNumberToString(source, 'armorPiercing');
+      }
+    }
     return super.migrateData(source);
   }
 }
@@ -199,7 +209,7 @@ export class ComponentData extends GearData {
     schema.isBaseHull = new fields.BooleanField({ required: true, initial: false});
     schema.rollModifier = new fields.StringField({...requiredBlankString});
     schema.rateOfFire = new fields.StringField({...requiredBlankString});
-    schema.armorPiercing = new fields.NumberField({...requiredInteger, initial: 0});
+    schema.armorPiercing = new fields.StringField({required: true, blank: false, initial: "0" });
     schema.actorLink = new fields.StringField({...requiredBlankString});
     schema.hardened = new fields.BooleanField({ required: true, initial: false});
     schema.ammunition = makeResourceField(0, 0);
@@ -212,6 +222,11 @@ export class ComponentData extends GearData {
     if ("purchasePrice" in source) {
       migrateStringToNumber(source, "purchasePrice");
     }
+    if ("armorPiercing" in source) {
+      if (typeof source.armorPiercing !== 'string') {
+        migrateNumberToString(source, 'armorPiercing');
+      }
+    }
     return super.migrateData(source);
   }
 }

src/module/entities/TwodsixActiveEffect.ts

@@ -37,9 +37,13 @@ export class TwodsixActiveEffect extends ActiveEffect {
    */
   async _onCreate(data: object, options: object, userId: string):void {
     await super._onCreate(data, options, userId);
-    if(game.userId === userId  && this.parent?.type === 'traveller') {
+    if (game.userId === userId  && this.parent?.type === 'traveller') {
       await checkEncumbranceStatus(this);
     }
+    // A hack to fix a bug in v13
+    if (data.changes?.length === 0) {
+      data.changes.push({});
+    }
   }
 
   /**
@@ -101,13 +105,15 @@ async function checkEncumbranceStatus (activeEffect:TwodsixActiveEffect):void {
 function changesEncumbranceStat(activeEffect:TwodsixActiveEffect):boolean {
   if (activeEffect.changes.length > 0) {
     for (const change of activeEffect.changes) {
-      if (change.key.includes('system.characteristics.strength.value')  ||
-          change.key.includes('system.characteristics.strength.current') ||
-          change.key.includes('system.characteristics.strength.mod') ||
-          (change.key.includes('system.characteristics.endurance.value') && ['CEATOM', "BARBARIC"].includes(game.settings.get('twodsix', 'ruleset'))) ||
-          change.key.includes('system.encumbrance.max') ||
-          change.key.includes('system.encumbrance.value')) {
-        return true;
+      if (change.key){
+        if (change.key.includes('system.characteristics.strength.value')  ||
+        change.key.includes('system.characteristics.strength.current') ||
+        change.key.includes('system.characteristics.strength.mod') ||
+        (change.key.includes('system.characteristics.endurance.value') && ['CEATOM', "BARBARIC"].includes(game.settings.get('twodsix', 'ruleset'))) ||
+        change.key.includes('system.encumbrance.max') ||
+        change.key.includes('system.encumbrance.value')) {
+          return true;
+        }
       }
     }
   }