Fix hooks and ship sheet issues #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
Closed
marvin9257
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Oct 2, 2022
## [2.4.3](v2.4.2...v2.4.3) (2022-10-02) ### Bug Fixes * hooks and ship sheet issues ([#1133](#1133)) ([306de10](306de10))
|
🎉 This PR is included in version 2.4.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
bug fixes
What is the current behavior? (You can also link to an open issue here)
Some hooks that call async function don't behave as expected
Ship price includes vehicle costs
Vehicle sub component should be labeled "Vehicles & Craft"
Missing dock component type
No hardened field for components
Ship financial fields don't allow for number punctuation
Can't specify "DD" for destructive damage
No associated skill listing for armament components
Ship component DM and Rating fields always shown
No price per 100 ton option
No shipping size for vehicles
What is the new behavior (if this is a feature change)?
Fix hook calls so that async function is isolated
Do not include vehicle costs in ship price calc
Relabel vehicle component
Add Dock component type
Add hardened field
Change ship financial fields to strings and make auto calc use punctuation appropriate to language preferences
Allow "DD" for damage rolls
Add associated skill name field for armament components
Make component ratings and DM/roll modifiers optional
Add a price per 100 ton option for components
Add shipping size field for vehicles
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Address QoL Suggestions Part 2 #1123