Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve taking damage #222

Closed
xdy opened this issue Dec 6, 2020 · 3 comments
Closed

Improve taking damage #222

xdy opened this issue Dec 6, 2020 · 3 comments
Assignees
@jonepatr
Labels
released on @development released

Comments

@xdy
Copy link
Owner

xdy commented Dec 6, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.
Currently only manual entry per characteristic and dragging with automatic handling is supported.

Describe the solution you'd like

  • Shift-clicking a damage field, or shift-dragging damage should open a dialog with at least these options:
    1 Ignore all/x points/half of armor value.
    2 Edit the damage value (to handle a forgotten bonus or penalty)
  • It should be possible to apply damage to all selected/targeted tokens from a button on the chat (maybe this should also/instead give access to the above? I.e. the button should just open the dialog.)
  • Combine the 'to hit' and 'damage' rolls into one chat message.
  • Make it possible to heal characters (other than through manually editing each characteristic damage field), probably using the above-mentioned dialog. (Though, healing probably shouldn't be affected by armor. :)
  • Apply suitable states on the character depending on the amount of damage taken. (Injured, Unconscious, Dead, etc)
  • Make sure the dice values are visible on a tooltip or expanding section.

Describe alternatives you've considered
Keep it as it is.

Additional context
https://discord.com/channels/170995199584108546/554492873190670336/785181815958011995 for an example of joining two rolls into one chat message.
Rules:
https://www.orffenspace.com/cepheus-srd/personal-combat.html#damage
https://www.orffenspace.com/cepheus-srd/personal-combat.html#armor
@xdy xdy mentioned this issue Dec 21, 2020
Closed
@jonepatr jonepatr added this to the 0.8 milestone Jan 20, 2021
@jonepatr jonepatr self-assigned this Feb 18, 2021
jonepatr added a commit to jonepatr/twodsix-foundryvtt that referenced this issue Mar 21, 2021
@jonepatr
fix: improve deal damage to actors
1f4f8aa 
Currently there is only an automated way of dealign damage to actors
this change brings up a dialog for all players who own an actor and
let them distribute the damage among the attributes. Holding shift will
use the old behavior and no dialog will be shown.
This change also adds the ability to target enemies when shooting.

Fix xdy#222
This was referenced Mar 21, 2021
Closed
Closed
jonepatr added a commit to jonepatr/twodsix-foundryvtt that referenced this issue Mar 21, 2021
@jonepatr
fix: improve deal damage to actors
bc4cb8e 
Currently there is only an automated way of dealign damage to actors
this change brings up a dialog for all players who own an actor and
let them distribute the damage among the attributes. Holding shift will
use the old behavior and no dialog will be shown.
This change also adds the ability to target enemies when shooting.

Fix xdy#222
jonepatr added a commit to jonepatr/twodsix-foundryvtt that referenced this issue Mar 21, 2021
@jonepatr
fix: improve deal damage to actors
f24e591 
Currently there is only an automated way of dealign damage to actors
this change brings up a dialog for all players who own an actor and
let them distribute the damage among the attributes. Holding shift will
use the old behavior and no dialog will be shown.
This change also adds the ability to target enemies when shooting.

Fix xdy#222
jonepatr added a commit to jonepatr/twodsix-foundryvtt that referenced this issue Mar 21, 2021
@jonepatr
fix: improve deal damage to actors
dd80c8f 
Currently there is only an automated way of dealign damage to actors
this change brings up a dialog for all players who own an actor and
let them distribute the damage among the attributes. Holding shift will
use the old behavior and no dialog will be shown.
This change also adds the ability to target enemies when shooting.

Fix xdy#222
jonepatr added a commit to jonepatr/twodsix-foundryvtt that referenced this issue Mar 22, 2021
@jonepatr
fix: improve deal damage to actors
030ae76 
Currently there is only an automated way of dealign damage to actors
this change brings up a dialog for all players who own an actor and
let them distribute the damage among the attributes. Holding shift will
use the old behavior and no dialog will be shown.
This change also adds the ability to target enemies when shooting.

Fix xdy#222
jonepatr added a commit to jonepatr/twodsix-foundryvtt that referenced this issue Mar 22, 2021
@jonepatr
fix: improve deal damage to actors
d5c1bc1 
Currently there is only an automated way of dealign damage to actors
this change brings up a dialog for all players who own an actor and
let them distribute the damage among the attributes. Holding shift will
use the old behavior and no dialog will be shown.
This change also adds the ability to target enemies when shooting.

Fix xdy#222
xdy pushed a commit that referenced this issue Mar 27, 2021
@jonepatr @xdy
fix: improve deal damage to actors
ac47ecc 
Currently there is only an automated way of dealign damage to actors
this change brings up a dialog for all players who own an actor and
let them distribute the damage among the attributes. Holding shift will
use the old behavior and no dialog will be shown.
This change also adds the ability to target enemies when shooting.

Fix #222
github-actions bot pushed a commit that referenced this issue Mar 27, 2021
@semantic-release-bot
chore(release): 0.7.24-development.1 [skip ci]
9aef594 
## [0.7.24-development.1](v0.7.23...v0.7.24-development.1) (2021-03-27)

### Bug Fixes

* improve deal damage to actors ([ac47ecc](ac47ecc)), closes [#222](#222)
@github-actions
Copy link

🎉 This issue has been resolved in version 0.7.24-development.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

xdy pushed a commit that referenced this issue Mar 28, 2021
@jonepatr @xdy
fix: improve deal damage to actors
b5822ac 
Currently there is only an automated way of dealign damage to actors
this change brings up a dialog for all players who own an actor and
let them distribute the damage among the attributes. Holding shift will
use the old behavior and no dialog will be shown.
This change also adds the ability to target enemies when shooting.

Fix #222
xdy pushed a commit that referenced this issue Mar 28, 2021
@semantic-release-bot @xdy
chore(release): 0.7.24-development.1 [skip ci]
f7dcaa5 
* improve deal damage to actors ([ac47ecc](ac47ecc)), closes [#222](#222)
github-actions bot pushed a commit that referenced this issue Mar 28, 2021
@semantic-release-bot
chore(release): 0.7.25-development.1 [skip ci]
aa3fabd 
## [0.7.25-development.1](v0.7.24...v0.7.25-development.1) (2021-03-28)

### Bug Fixes

* improve deal damage to actors ([b5822ac](b5822ac)), closes [#222](#222)
* Improve setting text ([f3ef1c4](f3ef1c4))
* Rebase on master, update package-lock.json, make a new development release. ([c701982](c701982))
@github-actions
Copy link

🎉 This issue has been resolved in version 0.7.25-development.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

xdy pushed a commit that referenced this issue Mar 28, 2021
@jonepatr @xdy
fix: improve deal damage to actors
b9e12c9 
Currently there is only an automated way of dealign damage to actors
this change brings up a dialog for all players who own an actor and
let them distribute the damage among the attributes. Holding shift will
use the old behavior and no dialog will be shown.
This change also adds the ability to target enemies when shooting.

Fix #222
xdy pushed a commit that referenced this issue Mar 28, 2021
@semantic-release-bot @xdy
chore(release): 0.7.24-development.1 [skip ci]
3e5d9df 
* improve deal damage to actors ([ac47ecc](ac47ecc)), closes [#222](#222)
xdy pushed a commit that referenced this issue Mar 28, 2021
@semantic-release-bot @xdy
chore(release): 0.7.25-development.1 [skip ci]
481efb3 
* improve deal damage to actors ([b5822ac](b5822ac)), closes [#222](#222)
* Improve setting text ([f3ef1c4](f3ef1c4))
* Rebase on master, update package-lock.json, make a new development release. ([c701982](c701982))
@xdy xdy closed this as completed in 748b21f Mar 28, 2021
@github-actions
Copy link

🎉 This issue has been resolved in version 0.7.26 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

jonepatr added a commit to jonepatr/twodsix-foundryvtt that referenced this issue Nov 20, 2021
@xdy @jonepatr @semantic-release-bot
Development (xdy#452)
70d7543 
* fix: improve deal damage to actors

Currently there is only an automated way of dealign damage to actors
this change brings up a dialog for all players who own an actor and
let them distribute the damage among the attributes. Holding shift will
use the old behavior and no dialog will be shown.
This change also adds the ability to target enemies when shooting.

Fix xdy#222

* chore(release): 0.7.24-development.1 [skip ci]

* improve deal damage to actors ([ac47ecc](xdy@ac47ecc)), closes [xdy#222](xdy#222)

* fix: Improve setting text

* chore(release): 0.7.24-development.2 [skip ci]

* Improve setting text ([b660729](xdy@b660729))

* fix: Rebase on master, update package-lock.json, make a new development release.

* chore(release): 0.7.25-development.1 [skip ci]

* improve deal damage to actors ([b5822ac](xdy@b5822ac)), closes [xdy#222](xdy#222)
* Improve setting text ([f3ef1c4](xdy@f3ef1c4))
* Rebase on master, update package-lock.json, make a new development release. ([c701982](xdy@c701982))

Co-authored-by: Patrik Jonell <[email protected]>
Co-authored-by: semantic-release-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonepatr jonepatr

Labels
released on @development released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xdy @jonepatr