fix: Fixes a dice roll bug @marvin9257 found. (Basically, it sometime…

…s double-counted the difficulty.) Hopefully it doesn't break some other usecase...
xdy · Nov 6, 2020 · 0e50dff · 0e50dff
1 parent 3b49b93
commit 0e50dff
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/src/module/utils/TwodsixRolls.ts b/src/module/utils/TwodsixRolls.ts
@@ -81,13 +81,12 @@ export class TwodsixRolls {
       difficultyString += ` (${difficulty.target}+)`;
     }
 
-    if (game.settings.get('twodsix', 'difficultiesAsTargetNumber')) {
+    if (!game.settings.get('twodsix', 'difficultiesAsTargetNumber') && !showEffect) {
       if (difficulty.mod !== 0) {
         rollParts.push("" + difficulty.mod);
       }
-    } else {
-      rollParts.push("" + difficulty.mod);
     }
+
     flavorParts.unshift(difficultyString);
 
     flavorParts.unshift(game.i18n.localize("TWODSIX.Rolls.Rolling") + ":");
@@ -227,12 +226,10 @@ export class TwodsixRolls {
       }
     }
 
-    if (game.settings.get('twodsix', 'difficultiesAsTargetNumber')) {
+    if (!game.settings.get('twodsix', 'difficultiesAsTargetNumber') && !showEffect) {
       if (difficulty.mod !== 0) {
         rollParts.push("" + difficulty.mod);
       }
-    } else {
-      rollParts.push("" + difficulty.mod);
     }
 
     flavorParts.push(label);