Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench: Add minimal ASV example #3936

Merged
merged 9 commits into from
Feb 25, 2025
Merged

Conversation

EdmundGoodman
Copy link
Collaborator

This adds a very minimal example of using ASV to benchmark importing dialects.

Changes

  • Add "bench" extra to optionally install ASV
  • Add additional make targets to run and preview ASV
  • Add configuration file for ASV
  • Add microbenchmark file for importing the arith and builtin dialects

Future work

  1. Add profiling functionality from bench_utils.py and optional "profile" extra to install profilers
  2. Incrementally review and add existing benchmarks from xdsl-bench
  3. Open call for further benchmarks as desired

@EdmundGoodman EdmundGoodman added the bench Benchmark related changes label Feb 18, 2025
@EdmundGoodman EdmundGoodman self-assigned this Feb 18, 2025
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 90.12%. Comparing base (b4ec8eb) to head (91e81f2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
benchmarks/microbenchmarks.py 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3936      +/-   ##
==========================================
- Coverage   90.13%   90.12%   -0.02%     
==========================================
  Files         458      459       +1     
  Lines       58317    58325       +8     
  Branches     5706     5706              
==========================================
  Hits        52563    52563              
- Misses       4349     4357       +8     
  Partials     1405     1405              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this needs a lock update otherwise gtg!

@superlopuh superlopuh merged commit 23c4d3d into main Feb 25, 2025
16 checks passed
@superlopuh superlopuh deleted the edmundgoodman/benchmarks-init branch February 25, 2025 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bench Benchmark related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants