import conventions

[georgebisbas]

Initiating discussion about a convention on import order

[superlopuh]

Looks like there's no way to do this automatically: google/yapf#813

I'm happy to take this if no-one else feels like it, it's a nit but can be therapeutic to do sometimes. I also think we should do it in a commit that is ignored by git blame.

[webmiche]

There seem to be some tools that claim to do this (at least somewhat) (https://pypi.org/project/reorder-python-imports/ and https://pypi.org/project/isort/).

[webmiche]

Also https://pypi.org/project/pylint/ seems to do something like that.

[webmiche]

Let me link the issue here :)

[webmiche]

Also, I want to mention that we have some weird behavior around imports due to how mlirs python bindings work. Effectively, we have some imports that need to be order properly, which might just be bad engineering, but we did not find a better approach at the time, IIRC.

[georgebisbas]

The convention we follow in Devito is:

# first import specific parts of other tools
from functools import partial

# Then import tools as a whole
import numpy as np

# Then import project specific things
from devito.core.operator import CoreOperator, CustomOperator, ParTile
from devito.exceptions import InvalidOperator

[superlopuh]

We have this working! Closing