-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convention for imports #147
Comments
I have used |
I have heard that enforcing an order on imports (like we do in the mlir converter) is bad style (here, e.g.). I feel that the fundamental problem is more in the python bindings than in our code, but I guess changing that would be very hard, so we might want to do some more engineering. |
ruff decides this for us now! |
We just merged George PR that remove star imports from imports.
I feel that there are other conventions we should follow for imports, and I'm not really aware of the ones that are used in practice.
@georgebisbas, @webmiche, @ingomueller-net, do you have good pointers for conventions that are normally used, and if possible, CIs that would enforce that?
The text was updated successfully, but these errors were encountered: