KAFKA-13391: don't fsync directory on Windows OS (apache#11426)

Reviewers: Cong Ding <[email protected]>, Jun Rao <[email protected]>
xdgrulez · Dec 22, 2021 · 1b9a177 · 1b9a177
1 parent e0f5f24
commit 1b9a177
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/clients/src/main/java/org/apache/kafka/common/utils/Utils.java b/clients/src/main/java/org/apache/kafka/common/utils/Utils.java
@@ -948,10 +948,12 @@ public static void atomicMoveWithFallback(Path source, Path target, boolean need
     /**
      * Flushes dirty directories to guarantee crash consistency.
      *
+     * Note: We don't fsync directories on Windows OS because otherwise it'll throw AccessDeniedException (KAFKA-13391)
+     *
      * @throws IOException if flushing the directory fails.
      */
     public static void flushDir(Path path) throws IOException {
-        if (path != null) {
+        if (path != null && !OperatingSystem.IS_WINDOWS) {
             try (FileChannel dir = FileChannel.open(path, StandardOpenOption.READ)) {
                 dir.force(true);
             }