Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.16.0 does not work with Python 2.7 anymore #44

Closed
hoechenberger opened this issue Sep 27, 2019 · 5 comments · Fixed by #45
Closed

Version 1.16.0 does not work with Python 2.7 anymore #44

hoechenberger opened this issue Sep 27, 2019 · 5 comments · Fixed by #45

Comments

@hoechenberger
Copy link

hoechenberger commented Sep 27, 2019

$ python -V
Python 2.7.15
$ python -c 'import pyxdf'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/Users/hoechenberger/miniconda3/envs/pyxdf/lib/python2.7/site-packages/pyxdf/__init__.py", line 11, in <module>
    from .pyxdf import load_xdf, resolve_streams, match_streaminfos
  File "/Users/hoechenberger/miniconda3/envs/pyxdf/lib/python2.7/site-packages/pyxdf/pyxdf.py", line 746
    chunk = {**chunk, **_parse_streamheader(xml)}
              ^
SyntaxError: invalid syntax

Metadata in setup.py says it should be compatible with both Py2 and Py3:
https://github.com/xdf-modules/xdf-python/blob/049aef3486040851f53ca710cee761c796b6835f/setup.py#L63-L64

@cbrnr
Copy link
Contributor

cbrnr commented Sep 27, 2019

OK, we should remove Python 2 in the metadata then.

cbrnr added a commit that referenced this issue Sep 27, 2019
@cboulay
Copy link
Contributor

cboulay commented Sep 27, 2019

I know Python 2 is EOL and we really shouldn't be putting any resources into supporting it. That being said, I know some scientific equipment runs only on really old computers and works only with really old software that can't be updated, so some users might not have a choice. If anyone can present a compelling argument to include Python 2 support then maybe we can figure out how to do that.

@hoechenberger
Copy link
Author

Just for the record, I personally couldn't care less about Py2. Just incidentally figured that Py2 wasn't working anymore as an automated build of the pyxdf conda-forge package failed.

@tstenner
Copy link
Contributor

Right, that's why pylsl should drop it any time soon.

Reading the data back in isn't one of those infrastructure projects where some ancient program/library has to be kept. I don't have the stats, but I guess most of the postprocessing will run on conda so I'd argue Python 3.5 or whatever the second most recent Ubuntu LTS ships is old enough.

@cbrnr
Copy link
Contributor

cbrnr commented Sep 28, 2019

Even if someone really needs to load XDF files on an ancient platform (which I doubt because this is part of data analysis and not recording), they can still use the old 1.15 release.

@cbrnr cbrnr closed this as completed in #45 Sep 28, 2019
cbrnr added a commit that referenced this issue Sep 28, 2019
* Remove Python 2 from setup.py

Fixes #44.

* Add changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants