Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor.destruct throws error #543

Closed
Sayan751 opened this issue Oct 30, 2020 · 0 comments
Closed

editor.destruct throws error #543

Sayan751 opened this issue Oct 30, 2020 · 0 comments
Labels

Comments

@Sayan751
Copy link

Jodit Version: 3.4.xxxxx

Browser: Chrome/FF
OS: Windows
Is React App: False

Code

// instantiate
this.editor = new Jodit(this.textArea, {});

// Later in the teardown phase
this.editor.destruct();

Expected behavior:

The destruct should have worked without any error.

Actual behavior:

It throws error on the following line.

node.classList.toggle('jodit_fullsize-box_true', enable);

As a workaround, I need to initialize the editor as following.

this.editor = new Jodit(this.textArea, { globalFullSize: false });

It would be nice such workaround can be avoided, especially when I am not using the editor in fullsize mode. In fact, I am not even sure what this plugin is for. Personal curiosity: Why the default value of globalFullSize is true anyway?

Lastly, let me say that this editor is amazing so far. Thank you for developing and maintaining this.

@xdan xdan added the bug label Oct 30, 2020
xdan added a commit that referenced this issue Oct 31, 2020
@xdan xdan closed this as completed Dec 19, 2020
vinhtranchau added a commit to vinhtranchau/jodit-repo that referenced this issue Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants