Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two TestThreadedProgressObservers unit tests failing #1104

Closed
pont-us opened this issue Jan 10, 2025 · 0 comments · Fixed by #1105
Closed

Two TestThreadedProgressObservers unit tests failing #1104

pont-us opened this issue Jan 10, 2025 · 0 comments · Fixed by #1105
Assignees
@pont-us

Comments

@pont-us
Copy link
Member

pont-us commented Jan 10, 2025

Describe the bug

On every run of the unit test suite,

FAILED test/core/gen2/test_progress.py::TestThreadedProgressObservers::test_threaded_progress_on_begin - RuntimeError: Patch is already started
FAILED test/core/gen2/test_progress.py::TestThreadedProgressObservers::test_threaded_progress_on_end - RuntimeError: Patch is already started

To Reproduce
Steps to reproduce the behavior:

  1. Check out main (e.g. at 7cce4f3)
  2. Run the unit tests
  3. See errors

Expected behavior
All unit tests pass, including the aforementioned.

Screenshots
n/a

Additional context
These used to pass, and have presumably started failing due to a dependency update.
@pont-us pont-us self-assigned this Jan 10, 2025
pont-us added a commit that referenced this issue Jan 10, 2025
@pont-us
Fix typos in TestThreadedProgressObservers tests
0fb6508 
test_threaded_progress_on_begin and test_threaded_progress_on_end
were calling stop() on _patch rather than _mock_patch(), producing
an error on the subsequent _mock_patch.start() (since it was
already started, and hadn't been stopped). Corrected in this commit.

Fixes #1104
@pont-us pont-us mentioned this issue Jan 10, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pont-us pont-us

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix typos in TestThreadedProgressObservers tests xcube-dev/xcube
1 participant
@pont-us