Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing #420 (for CCI Toolbox) #44

Merged
merged 4 commits into from
Apr 9, 2021
Merged

Conversation

forman
Copy link
Member

@forman forman commented Mar 10, 2021

EDIT

Requires merged xcube-dev/xcube#421

Copy link
Member

@pont-us pont-us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine for minimal compliance with the API change -- I have opened #45 for proper handling of the new parameter at a later date.

xcube_cds/store.py Show resolved Hide resolved
xcube_cds/store.py Show resolved Hide resolved
@forman forman requested a review from TonioF March 16, 2021 10:17
@TonioF TonioF mentioned this pull request Mar 24, 2021
@pont-us
Copy link
Member

pont-us commented Apr 9, 2021

xcube-dev/xcube#421 is now merged so merging this PR too. CI tests are failing due to new dependency on no-yet-released xcube 0.8, but all tests pass with latest repo version of xcube.

@pont-us pont-us merged commit 853eebc into master Apr 9, 2021
@pont-us pont-us deleted the forman-420-include_attrs branch April 23, 2021 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants