Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Xcode download URL #478

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Xcode download URL #478

wants to merge 1 commit into from

Conversation

Nezz
Copy link

@Nezz Nezz commented Oct 9, 2023

The URL was broken sometime this summer. I have verified that the suggested workaround in #476 (comment) works on our machines and submitted it as a PR. Credits belongs to @bmarkowww.

Fixes #476

@rogerluan
Copy link
Collaborator

rogerluan commented Oct 9, 2023

@Nezz Thank you for this PR, but unfortunately we're under a sunset period. Please refer to https://github.com/xcpretty/xcode-install/blob/master/MIGRATION.md

Moreover, xcodes uses this same URL https://github.com/XcodesOrg/xcodes/blob/71e97f8103fe484c4b28a81191e75b41498152d1/Sources/XcodesKit/URLRequest%2BApple.swift#L6C16-L6C29 and works just fine, so not sure if that's really what's causing the issue here?

@Nezz
Copy link
Author

Nezz commented Oct 9, 2023

@Nezz Thank you for this PR, but unfortunately we're under a sunset period. Please refer to https://github.com/xcpretty/xcode-install/blob/master/MIGRATION.md

We are still using xcode-install because it works with accounts that don't have 2FA, whereas I couldn't get that working with xcodes. One less fix I guess before we need to switch to xcodereleases.com?

Moreover, xcodes uses this same URL https://github.com/XcodesOrg/xcodes/blob/71e97f8103fe484c4b28a81191e75b41498152d1/Sources/XcodesKit/URLRequest%2BApple.swift#L6C16-L6C29 and works just fine, so not sure if that's really what's causing the issue here?

I'm not sure how it works there, I checked and it is returning a "not found" HTML.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot install xcode with command xcversion install
2 participants