bugfix/frame-fw14xx #125
bugfix/frame-fw14xx #125
Conversation
|
Hi, I hit the same problem with a Frame 55" 2019 (model name: QE55LS03RAUXZG) and unfortunately your gist does not fix it for me. This is the output (sorry for using the same picture, just used it for this test): ` DEBUG:samsungtvws.rest:Get device info via rest api DEBUG:urllib3.connectionpool:Starting new HTTPS connection (1): cdn.midjourney.com:443 DEBUG:samsungtvws.connection:SamsungTVWS websocket event: {'data': {'clients': [{'attributes': {'name': None}, 'connectTime': 1683104313024, 'deviceName': 'Smart Device', 'id': '719937b2-785a-4188-b013-7590ccbeaa8', 'isHost': True}, {'attributes': {'name': 'U2Ftc3VuZ1R2UmVtb3Rl'}, 'connectTime': 1683140350870, 'deviceName': 'U2Ftc3VuZ1R2UmVtb3Rl', 'id': 'b8a232a1-c2ff-4ca6-bdc3-e97c99aa78c2', 'isHost': False}], 'id': 'b8a232a1-c2ff-4ca6-bdc3-e97c99aa78c2'}, 'event': 'ms.channel.connect'} DEBUG:samsungtvws.connection:SamsungTVWS websocket event: {'data': {}, 'event': 'ms.channel.ready'} DEBUG:samsungtvws.connection:SamsungTVWS websocket event: {'data': '{"id":"89650cb5-35c7-461b-9f3f-38a48e7343a7","event":"error","request_data":"{\"request\": \"send_image\", \"file_type\": \"png\", \"conn_info\": {\"d2d_mode\": \"socket\", \"connection_id\": 4102090466, \"id\": \"89650cb5-35c7-461b-9f3f-38a48e7343a7\"}, \"image_date\": \"2023:05:03 20:59:11\", \"matte_id\": \"none\", \"file_size\": 2422643, \"id\": \"89650cb5-35c7-461b-9f3f-38a48e7343a7\"}","error_code":"-1","target_client_id":"b8a232a1-c2ff-4ca6-bdc3-e97c99aa78c2"}', 'event': 'd2d_service_message', 'from': '719937b2-785a-4188-b013-7590ccbeaa8'} |
|
@fhaertig the gist alone does not fix the issue, and the debug messages seems to return expected results. The following + the gist should work on 2019 samsung TVs. |
|
silly me... thanks for the hint. But that doesn't quite fixes it, either. It looks like the file upload starts (a lot of byte codes are printed) and then it stops somehow, always at the same position. I'll have to investigate further |
|
More insight: So apparently it never finishes the upload, as already mentioned in #106 because of a failing d2d connection command: DEBUG:samsungtvws.connection:SamsungTVWS websocket event: {'data': '{"id":"86860dff-7e7f-435c-b817-f171a60882e2","event":"error","request_data":"{\"request\": \"send_image\", \"file_type\": \"jpg\", \"conn_info\": {\"d2d_mode\": \"socket\", \"connection_id\": 2980860187, \"id\": \"86860dff-7e7f-435c-b817-f171a60882e2\"}, \"image_date\": \"2023:05:12 14:37:07\", \"matte_id\": \"none\", \"file_size\": 132906, \"id\": \"86860dff-7e7f-435c-b817-f171a60882e2\"}","error_code":"-1","target_client_id":"f67a4cb4-d177-49d7-bd5d-c2d4c66a06f"}', 'event': 'd2d_service_message', 'from': 'b8a4388-b1c3-4751-939e-32b727641675'} |
|
Have you tried sending my command, without the
|
Even with bugfix, same error than @fhaertig. I've tried with/out [encrypted,async]. No improvement. Thank you all for trying to help us. |
|
Weirdly we have ~ the same model QE55LS03RAUXZT. I did a full reset, though… |
@thypon While it wasn't working, you made a full reset and it finally worked ? Or, you started with a full reset and, perhaps, it helped. |
I remember I was not even able to connect to the official Samsung app before the reset. I think the last firmware borked the connection. I then proceeded to reverse engineer the app communication and implemented the fix here. |
|
Thanks to the debugger, I've been able to identify the very moment at which program stucks. Here is the stack trace when it stucks : Program's debug has been enabled. Here is the program's output (redacted). Last line has been cut as it weights 6MB 😲 (see capture at the end of this post) :
Nothing happens after it stucks until killing the program or powering off the TV. |
|
Hi @thypon, I tried to use your code, but keep getting this error below. My TV is QN43LS03RAFXZA, and FW is 1406.4. Any help is much appreciated. Traceback (most recent call last): During handling of the above exception, another exception occurred: Traceback (most recent call last): |
|
Hey @ipus2017 , unfortunately I don't own all the devices to test for, but it takes some hours to reverse engineer the protocol and understand what is going on + adapt the code. It still works fine on my 55" 2019 |
OK, thanks for your quick response What is your FW? |
|
1406 QE55LS03RAUXZT model. |
|
The funny thing is I also have QN55LS03RAFXZA on FW 1406 and it also doesn't work with the same error. I hate Samsung :) This one works perfectly QN55LS03AAFXZA. |
|
QE55LS03RAUXZT might be a distinct model from QN55LS03RAFXZA. |
|
I'm also on QN55LS03RAFXZA running 1406 I've tried a few things but always seem to run into a timeout issue when uploading images to the TV: Any pointers or things to try out to get this working would be appreciated. Thanks! |
|
Samsung depending on the version of Tizen and the version of FW usually remove these things so that we do not use them anymore. This type of functionality would really take them out of the package, in real world it is very difficult to understand if they really will work for all users. |
|
I was able to fix it for my TV - QN55LS03AAFXZA. Try attached art.py file.
…On Thu, Mar 14, 2024 at 11:44 AM DSR! ***@***.***> wrote:
Samsung depending on the version of Tizen and the version of FW usually
remove these things so that we do not use them anymore.
But within the same family that should be running the same versions of
Tizen and practically the same FW is really rare to fail.
This type of functionality would really take them out of the package, in
real world it is very difficult to understand if they really will work for
all users.
—
Reply to this email directly, view it on GitHub
<#125 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGHWHNBMX5YHLMN3TQZYZQLYYHAUXAVCNFSM6AAAAAAXTLSXZ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJXG43DAMBWG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
| elif "matte_list" in data: | ||
| return json.loads(data["matte_list"]) |
There was a problem hiding this comment.
I think it's better here to fail hard.
| elif "matte_list" in data: | |
| return json.loads(data["matte_list"]) | |
| return json.loads(data["matte_list"]) |
Another option is to raise an exception
if "matte_type_list" in data:
return json.loads(data["matte_type_list"])
if "matte_list" in data:
return json.loads(data["matte_list"])
raise ...| "connection_id": random.randrange(4 * 1024 * 1024 * 1024), | ||
| "id": self.art_uuid, | ||
| try: | ||
| response = self._send_art_request( |
There was a problem hiding this comment.
I think here it would be better to split it completely into two methods:
try:
self._upload_v1(file, matte, file_type, date)
except exceptions.ResponseError:
self._upload_v2(file, matte, file_type, date)There was a problem hiding this comment.
won't have access to the TV 'till next month, will check later.
Thanks for the review!
@ipus2017 the attachment is not present. Please edit your comment and use drag-drop instead to upload the file. |
I had to rename it to txt, but here's the file |
@ipus2017 are there any significant changes to PR #125 opened by @thypon in the art.py file that you uploaded? I'm failing to see any. |
Tested on my 55" 2019 model, working good
I created this small script too which I use with my midjourney account to create artsy art: https://gist.github.com/thypon/9afca331d3f30e895e940421cfe0bef2
Solves: #106