Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failures with mtl-2.3 #15

Closed
sjakobi opened this issue May 22, 2022 · 1 comment · Fixed by #16
Closed

Build failures with mtl-2.3 #15

sjakobi opened this issue May 22, 2022 · 1 comment · Fixed by #16

Comments

@sjakobi
Copy link

sjakobi commented May 22, 2022

When I build this package with the mtl-2.3 release I get this failure:

src/Data/Aeson/Commit.hs:64:40: error:
    Not in scope: type constructor or class ‘ExceptT’
   |
64 | newtype Commit a = Commit {unCommit :: ExceptT [Parser Void] Parser a}
   |                                        ^^^^^^^

This build failure is due to haskell/mtl#117 which will be fixed in a follow-up release of mtl.

Building with a version of mtl that includes a fix to that issue, I'm getting

src/Data/Aeson/Commit.hs:73:3: error:
    Variable not in scope:
      lift :: Parser b -> ExceptT [Parser Void] Parser b
   |
73 |   lift $ post a
   |   ^^^^
jonascarpay added a commit that referenced this issue May 23, 2022
[#15] mtl 2.3 has a botched Control.Monad.Except export. We could work
around it with e.g. CPP, but luckily, we can also just use transformers
directly instead.
@jonascarpay jonascarpay mentioned this issue May 23, 2022
jonascarpay added a commit that referenced this issue May 23, 2022
[#15] mtl 2.3 has a botched Control.Monad.Except export. We could work
around it with e.g. CPP, but luckily, we can also just use transformers
directly instead.
jonascarpay added a commit that referenced this issue May 23, 2022
[#15] mtl 2.3 has a botched Control.Monad.Except export. We could work
around it with e.g. CPP, but luckily, we can also just use transformers
directly instead.
jonascarpay added a commit that referenced this issue May 23, 2022
[#15] mtl 2.3 has a botched Control.Monad.Except export. We could work
around it with e.g. CPP, but luckily, we can also just use transformers
directly instead.
@jonascarpay
Copy link
Contributor

Thanks for reporting, it should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants